“Your Second Amendment rights are under siege,” Mr. Trump said. “But they will never, ever be under siege as long as I am your president.”